New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ExperimentType to be set in 7_3_X #6416
Allow ExperimentType to be set in 7_3_X #6416
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_3_X. Allow ExperimentType to be set It involves the following packages: FWCore/Sources @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
I'm not so sure about this. Under which virtual function would this have to be called in order for the value the be used in an Event? I would think adding this as an additional argument to one of the present virtual functions would work better. |
6fb0a66
to
5a3fdf9
Compare
+1 |
gen changes trivial - bypassing - so complain if not ok |
Allow ExperimentType to be set in 7_3_X
Remi Mommsen discovered that there is no way to set the ExperimentType data member in ProducerSourceBase, which is the base class of FRDStreamSource.
This pull request fixes this problem in 7_3_X.
Remi requested the problem be fixed in 7_2_X and 7_3_X.
A separate pull request will be used for 7_2_X.
The member function setRunAndEventInfo() needed an additional argument.
All classes inheriting from ProducerSourceBase needed this addtional argument added.
At the moment, only FRDStreamSource actually sets the ExperimentType (done in this pull request).