Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ExperimentType to be set in 7_3_X #6416

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 14, 2014

Remi Mommsen discovered that there is no way to set the ExperimentType data member in ProducerSourceBase, which is the base class of FRDStreamSource.
This pull request fixes this problem in 7_3_X.
Remi requested the problem be fixed in 7_2_X and 7_3_X.
A separate pull request will be used for 7_2_X.
The member function setRunAndEventInfo() needed an additional argument.
All classes inheriting from ProducerSourceBase needed this addtional argument added.
At the moment, only FRDStreamSource actually sets the ExperimentType (done in this pull request).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_X.

Allow ExperimentType to be set

It involves the following packages:

FWCore/Sources

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

I'm not so sure about this. Under which virtual function would this have to be called in order for the value the be used in an Event? I would think adding this as an additional argument to one of the present virtual functions would work better.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Nov 19, 2014

+1
Changes in AlCa accomodate the sub-classes to the new interface.

@davidlange6
Copy link
Contributor

gen changes trivial - bypassing - so complain if not ok

davidlange6 added a commit that referenced this pull request Nov 19, 2014
@davidlange6 davidlange6 merged commit f97bfa9 into cms-sw:CMSSW_7_3_X Nov 19, 2014
@wmtan wmtan deleted the AllowExperimentTypeToBeSet7_3_X branch November 24, 2014 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants