Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors from using published datasets #6429

Merged
merged 1 commit into from Nov 19, 2014

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 15, 2014

This pull request fixes two errors in the All In One Validation Tool's interface to DAS, which currently does not function at all, requiring an extra step in specifying the data files to use.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_3_X.

Fix errors from using published datasets

It involves the following packages:

Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 19, 2014
Fix errors from using published datasets
@cmsbuild cmsbuild merged commit 212208d into cms-sw:CMSSW_7_3_X Nov 19, 2014
@hroskes hroskes deleted the fix-dataset-error-73X branch November 19, 2014 14:04
cmsbuild added a commit that referenced this pull request Dec 3, 2014
Backport of  #6429: Fix errors from using published datasets
@hroskes hroskes restored the fix-dataset-error-73X branch December 8, 2014 15:02
cmsbuild added a commit that referenced this pull request Dec 9, 2014
Backport of #6429: Fix errors from using published datasets
@hroskes hroskes deleted the fix-dataset-error-73X branch January 19, 2015 16:33
@hroskes hroskes restored the fix-dataset-error-73X branch February 4, 2015 16:04
@hroskes hroskes deleted the fix-dataset-error-73X branch February 4, 2015 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants