Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit initialization check to pythia8 interface (73x) #6455

Merged
merged 1 commit into from Nov 17, 2014

Conversation

bendavid
Copy link
Contributor

Previously failure in pythia8 initialization caused empty events to be produced and silently filtered out by the generator sequence, making the problem not obvious in central production. This will now cause the job to crash as it should in this case.

…a initialization fails (instead of just silently filtering out the empty events)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_3_X.

Add explicit initialization check to pythia8 interface (73x)

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 17, 2014
Add explicit initialization check to pythia8 interface (73x)
@cmsbuild cmsbuild merged commit 39f16d8 into cms-sw:CMSSW_7_3_X Nov 17, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants