Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warnings when lazy-download is not used. #6476

Merged
merged 1 commit into from Nov 18, 2014

Conversation

bbockelm
Copy link
Contributor

Previously, when lazy-download was not used because:

  • The cache directory was not writable,
  • The cache filesystem was too small, OR
  • The cache filesystem was thought to be on a remote filesystem,
    then lazy-download was turned off without warning.

This made debugging issues difficult - especially as turning off
lazy-download can cause merges to go many times slower. Whether lazy-download
is used is logged in the FrameworkJobReport - but often it takes an expert to decode
those!

We now issue a reasonably-worded warning when this happens.

Previously, when lazy-download was not used because:
- The cache directory was not writable,
- The cache filesystem was too small, OR
- The cache filesystem was thought to be on a remote filesystem,
then lazy-download was turned off without warning.

This made debugging issues difficult - especially as turning off
lazy-download can cause merges to go many times slower.

We now issue a reasonably-worded warning when this happens.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bbockelm (Brian Bockelman) for CMSSW_7_3_X.

Issue warnings when lazy-download is not used.

It involves the following packages:

Utilities/StorageFactory

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bbockelm
Copy link
Contributor Author

(I forgot to mention - the warnings only occur when lazy-download would otherwise have been used.)

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants