Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

73X - fix HadronAndPartonSelector for unknown generators #6486

Merged
merged 1 commit into from Nov 19, 2014
Merged

73X - fix HadronAndPartonSelector for unknown generators #6486

merged 1 commit into from Nov 19, 2014

Conversation

vadler
Copy link

@vadler vadler commented Nov 18, 2014

Forward port of #6485 :
A possibly invalid handle in the HadronAndPartonSelector is not dereferenced any more, before its validity has been checked.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Nov 18, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_3_X.

73X - fix HadronAndPartonSelector for unknown generators

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link
Author

vadler commented Nov 18, 2014

+1
Tested with CMSSW_7_3_X_2014-11-18-0200.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 24d243b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6486/987/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6486/987/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 19, 2014
@cmsbuild
Merge pull request #6486 from vadler/73X-fixHadronAndPartonSelectorFo…
a7340e6 
…rUnknownGenerators

73X - fix `HadronAndPartonSelector` for unknown generators
@cmsbuild cmsbuild merged commit a7340e6 into cms-sw:CMSSW_7_3_X Nov 19, 2014
@vadler vadler deleted the 73X-fixHadronAndPartonSelectorForUnknownGenerators branch November 19, 2014 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vadler @cmsbuild @davidlange6