Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when unschedule mode and customise_command are used together #6492

Merged

Conversation

srimanob
Copy link
Contributor

customise_commands will fail in unschedule mode because it's called before the module is load.

https://github.com/cms-sw/cmssw/blob/CMSSW_7_2_X/Configuration/Applications/python/ConfigBuilder.py#L2211-L2226

For example,
cmsDriver.py step3 --filein file:MUO-Phys14DR-00003_step2.root --fileout file:MUO-Phys14DR-00003.root --mc --eventcontent MINIAODSIM --runUnscheduled --datatier MINIAODSIM --conditions PHYS14_25_V1 --customise_commands 'process.patJetPartons.partonMode = cms.string("Pythia6")' --step PAT --python_filename MUO-Phys14DR-00003_3_cfg.py --no_exec --customise Configuration/DataProcessing/Utils.addMonitoring -n 20

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_7_2_X.

Fix when unschedule mode and customise_command are used together

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

I think we can replace the two ifs with the same set of commands by

if unsch==1 or not self._options.runUnscheduled:

?

@srimanob
Copy link
Contributor Author

Thanks David.
Fix as you suggest.

@cmsbuild
Copy link
Contributor

Pull request #6492 was updated. @cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please check and sign again.

davidlange6 added a commit that referenced this pull request Nov 20, 2014
Fix when unschedule mode and customise_command are used together
@davidlange6 davidlange6 merged commit a53445a into cms-sw:CMSSW_7_2_X Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants