Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some missing pieces for PreMixing #6501

Merged
merged 1 commit into from Nov 20, 2014

Conversation

mdhildreth
Copy link
Contributor

HcalSignalGenerator is only used with the DataMixer. Otherwise, one configuration line missing in ConfigBuilder. Please don't approve until David Lange has run one last round of identity tests.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_3_X.

Some missing pieces for PreMixing

It involves the following packages:

Configuration/Applications
SimCalorimetry/HcalSimAlgos

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request Nov 20, 2014
@davidlange6 davidlange6 merged commit 3c0d894 into cms-sw:CMSSW_7_3_X Nov 20, 2014
@cmsbuild
Copy link
Contributor

-1

Tested at: 69a0a8d
I ran the usual tests and I found errors in the following unit tests:

---> test TestFWCoreIntegrationStandalone had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6501/1012/summary.html

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants