Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back a plugin needed #6503

Merged
merged 1 commit into from Nov 20, 2014

Conversation

davidlange6
Copy link
Contributor

seems to be the simple fix for the problems in the IBs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_3_X.

add back a plugin needed

It involves the following packages:

CondCore/AlignmentPlugins

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1

On Thu, Nov 20, 2014 at 7:51 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @davidlange6
https://github.com/davidlange6 (David Lange) for CMSSW_7_3_X.

add back a plugin needed

It involves the following packages:

CondCore/AlignmentPlugins

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @nclopezo
https://github.com/nclopezo can you please review it and eventually
sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo you are the release manager for
this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#6503 (comment).

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@diguida
Copy link
Contributor

diguida commented Nov 20, 2014

@davidlange6 Thanks!
Sorry for overlooking the missing line :-(

@davidlange6
Copy link
Contributor Author

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants