Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have TriggerResults see all transitions #651

Merged
merged 1 commit into from Aug 29, 2013

Conversation

Dr15Jones
Copy link
Contributor

The FastTimerService requires that all modules see the beginJob transition
in order for it to register that module. A recent change to the framework made
the TriggerResults only see Stream based transitions since that is all it needed.
This change makes TriggerResults see all transitions again.

The FastTimerService requires that all modules see the beginJob transition
in order for it to register that module. A recent change to the framework made
the TriggerResults only see Stream based transitions since that is all it needed.
This change makes TriggerResults see all transitions again.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Have TriggerResults see all transitions

It involves the following packages:

FWCore/Integration
FWCore/Framework

@Dr15Jones, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

This fixes the last problem still left open after #636
Checked that this compiles and all framework unit tests pass.

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

@nclopezo can you please test this with a full build? It might have sense to have 4.64 tested as well.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Aug 29, 2013
Have TriggerResults see all transitions
@ktf ktf merged commit f182acf into cms-sw:CMSSW_7_0_X Aug 29, 2013
jpata pushed a commit to jpata/cmssw that referenced this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants