Pass address of pointer, not value, again

[wmtan]

In (at least) four places in the ROOT 6 specific conditions code, the address of a pointer to an object needed to be passed to an ObjectWithDict constructor.
Unfortunately, the value of the pointer was passed instead (missing '&').
Two of these four were fixed in pull request #6521.
This pull request fixes the two cases of this that were missed in the prior pull request.
Editorial comment: I hate code that is not type safe.
This request also does some minor optimization by avoiding unnecessary ObjectWithDict::typeOf() calls, since the return value is already known.
Please merge this request as soon as convenient.

[apfeiffer1]

+1

On Fri, Nov 21, 2014 at 11:26 PM, wmtan notifications@github.com wrote:

In (at least) four places in the ROOT 6 specific conditions code, the
address of a pointer to an object needed to be passed to an ObjectWithDict
constructor.
Unfortunately, the value of the pointer was passed instead (missing '&').
Two of these four were fixed in pull request #6521
#6521.
This pull request fixes the two cases of this that were missed in the
prior pull request.
Editorial comment: I hate code that is not type safe.
This request also does some minor optimization by avoiding unnecessary
ObjectWithDict::typeOf() calls, since the return value is already known.

Please merge this request as soon as convenient.

You can merge this Pull Request by running

git pull https://github.com/wmtan/cmssw PassAddressOfPointer

Or view, comment on, or merge it at:

#6555
Commit Summary

• Pass address of pointer, not value

File Changes

• M CondCore/ORA/src/OraPtrStreamer.cc
  https://github.com/cms-sw/cmssw/pull/6555/files#diff-0 (8)
• M CondCore/ORA/src/QueryableVectorStreamer.cc
  https://github.com/cms-sw/cmssw/pull/6555/files#diff-1 (8)

Patch Links:

• https://github.com/cms-sw/cmssw/pull/6555.patch
• https://github.com/cms-sw/cmssw/pull/6555.diff

—
Reply to this email directly or view it on GitHub
#6555.

Thanks,
cheers, andreas