guard the nPho histograms from double counting, should fix HI issues #6574
Conversation
|
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_3_X. guard the nPho histograms from double counting, should fix HI issues It involves the following packages: DQMOffline/EGamma @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
cmsbuild
added
comparison-pending
dqm-approved
fully-signed
orp-pending
and removed
comparison-pending
dqm-approved
fully-signed
orp-pending
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
This was forward ported to #6612. Please close this one if you do not need it in CMSSW_7_3_X. |
|
fix. needed in 73 as well. |
| { | ||
| nPho[cut][type][0]++; | ||
| nPho[cut][type][part]++; | ||
| } |
There was a problem hiding this comment.
why not just remove all of the added lines and replace [0] by [type] in the two lines above?
There was a problem hiding this comment.
Not my business, but that changes the logic, does it not?
On Thu Nov 27 2014 at 6:55:32 PM David Lange notifications@github.com
wrote:
In DQMOffline/EGamma/plugins/PhotonAnalyzer.cc:
@@ -887,8 +887,11 @@ void PhotonAnalyzer::analyze( const edm::Event& e, const edm::EventSetup& esup )
//filling photon histograms
nPho[cut][0][0]++;
nPho[cut][0][part]++;
- nPho[cut][type][0]++;
- nPho[cut][type][part]++;
- if(type != 0)
- {
nPho[cut][type][0]++;nPho[cut][type][part]++;- }
why not just remove all of the added lines and replace [0] by [type] in
the two lines above?—
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/6574/files#r21006980.
|
+1 |
guard the nPho histograms from double counting, should fix HI issues
In HI reco DQM, photons are being double-counted because in HI RECO we do not pre-select at the RECO level for isolated photons. Since most HI photons are not isolated according to the default cuts they have type==0 and get double-counted.