Pass address of iterators #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitten again by the non type safe interface of ROOT.
A ROOT6 function called next() taking two void* arguments is used by a proxy to iterate over an STL collection. The arguments should be the addresses of the begin and end iterators.
However, the ROOT6 specific conditions code was passing in the values of the iterators, rather than the addresses of the iterators.
This pull request fixes this problem, avoiding segfaults in several unit tests in CondCore packages. Four of the fixed tests actually now will pass, but most will fail later due to other problems.
Please merge this pull request as soon as convenient.