Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for root 5.34.22 #6590

Merged
merged 1 commit into from Nov 26, 2014
Merged

Changes for root 5.34.22 #6590

merged 1 commit into from Nov 26, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 25, 2014

Complete list of checksum / IORules changes as required by the new
version of root. This is the squashing of all the commits we had on the
CMSSW_7_3_DEVEL_X branch.

Complete list of checksum / IORules changes as required by the new
version of root. This is the squashing of all the commits we had on the
CMSSW_7_3_DEVEL_X branch.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Changes for root 5.34.22

It involves the following packages:

AnalysisDataFormats/EWK
AnalysisDataFormats/TopObjects
DataFormats/Alignment
DataFormats/BTauReco
DataFormats/CLHEP
DataFormats/CSCRecHit
DataFormats/CaloTowers
DataFormats/Candidate
DataFormats/CastorReco
DataFormats/Common
DataFormats/DTRecHit
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/FEDRawData
DataFormats/FWLite
DataFormats/GEMRecHit
DataFormats/GeometryVector
DataFormats/GsfTrackReco
DataFormats/HLTReco
DataFormats/HcalCalibObjects
DataFormats/HcalDetId
DataFormats/HcalIsolatedTrack
DataFormats/HcalRecHit
DataFormats/HepMCCandidate
DataFormats/JetReco
DataFormats/L1CSCTrackFinder
DataFormats/L1DTTrackFinder
DataFormats/L1GlobalCaloTrigger
DataFormats/L1GlobalMuonTrigger
DataFormats/L1GlobalTrigger
DataFormats/L1Trigger
DataFormats/LTCDigi
DataFormats/Luminosity
DataFormats/METReco
DataFormats/MuonDetId
DataFormats/MuonReco
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/Provenance
DataFormats/RPCRecHit
DataFormats/RecoCandidate
DataFormats/Scalers
DataFormats/SiPixelRawData
DataFormats/SiStripCommon
DataFormats/SiStripDetId
DataFormats/SiStripDigi
DataFormats/TauReco
DataFormats/TestObjects
DataFormats/TrackReco
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
DataFormats/V0Candidate
SimDataFormats/GeneratorProducts
SimDataFormats/JetMatching
SimDataFormats/Track
SimDataFormats/Vertex

The following packages do not have a category, yet:

DataFormats/GEMRecHit

@covarell, @cerminar, @Martin-Grunewald, @diguida, @rcastello, @bendavid, @perrotta, @civanch, @cmsbuild, @fwyzard, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @slava77, @mommsen, @vadler, @mmusich, @mulhearn, @nclopezo, @emeschi, @thuer, @monttj, @StoyanStoynev can you please review it and eventually sign? Thanks.
@TaiSakuma, @jpavel, @argiro, @threus, @venturia, @mmarionncern, @imarches, @ahinzmann, @acaudron, @lgray, @ferencek, @trocino, @Sam-Harper, @wmtan, @VinInn, @nhanvtran, @schoef, @amagitte, @abbiendi, @battibass, @wddgit, @makortel, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1
Tested at: dc39f02
I found an error when building:

>> Compiling capabilities tmp/slc6_amd64_gcc491/src/DataFormats/RPCRecHit/src/DataFormatsRPCRecHit/a/seal_cap.cc 
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc491/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/a/xr.cc
>> Building capability library tmp/slc6_amd64_gcc491/src/DataFormats/MuonDetId/src/DataFormatsMuonDetId/libDataFormatsMuonDetIdCapabilities.so
>> Checking EDM Class Version for src/DataFormats/MuonDetId/src/classes_def.xml in libDataFormatsMuonDetIdCapabilities.so
Automatic building of dictionaries now off
error: class 'edm::EventID' has a different checksum for ClassVersion 12. Increment ClassVersion to 13 and assign it to checksum 341254076
error: class 'edm::FileIndex::Element' has a different checksum for ClassVersion 12. Increment ClassVersion to 13 and assign it to checksum 1881476699
error: class 'edm::IndexIntoFile::RunOrLumiEntry' has a different checksum for ClassVersion 11. Increment ClassVersion to 12 and assign it to checksum 447201247
gmake: **\* [tmp/slc6_amd64_gcc491/src/DataFormats/Provenance/src/DataFormatsProvenance/libDataFormatsProvenanceCapabilities.so] Error 1
>> Compiling capabilities tmp/slc6_amd64_gcc491/src/DataFormats/GEMRecHit/src/DataFormatsGEMRecHit/a/seal_cap.cc 
>> Compiling capabilities tmp/slc6_amd64_gcc491/src/DataFormats/V0Candidate/src/DataFormatsV0Candidate/a/seal_cap.cc 


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6590/1164/summary.html

@ktf
Copy link
Contributor Author

ktf commented Nov 26, 2014

Ok, looks like the only way to test this is to do the full thing. Merging and updating root.

ktf added a commit that referenced this pull request Nov 26, 2014
@ktf ktf merged commit 943d0f0 into cms-sw:CMSSW_7_4_X Nov 26, 2014
@ktf ktf deleted the new-root-checksums branch November 26, 2014 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants