Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix track cluster remover template definition #6593

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Nov 25, 2014

in the migration from HLTTrackClusterRemover to TrackClusterRemover
I realized that in confDB we do not have the TrackClusterRemover template :(

it turned out to be due to the fact that no cfi is available for this module
moreover, this module is used by explicitly defining it in all tracking cff files !

=> this PR is meant for

  1. add trackClusterRemover_cfi.py file
    w/ default parameters which should be in as general as possible
  2. fix the handling of the input parameters w/in TrackClusterRemover
  3. update all (?) python configuration where there is an explicit definition of the TrackClusterRemover module,
    in order to instead import-and-clone the default template

this PR is needed for then letting the HLT config being migrated to use TrackClusterRemover (which is multithread safe), instead of HLTTrackClusterRemover which should not be maintained anymore ...

@Martin-Grunewald @perrotta , do I have to backport to 72x as well ?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

fix track cluster remover template definition

It involves the following packages:

RecoLocalTracker/SubCollectionProducers
RecoParticleFlow/PFTracking
RecoTracker/ConversionSeedGenerators
RecoTracker/IterativeTracking

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @appeltel, @mmarionncern, @makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @lgray, @nickmccoll, @jlagram, @gpetruc, @cerati, @VinInn, @threus, @dgulhan, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mtosi
Copy link
Contributor Author

mtosi commented Nov 25, 2014

runTheMatrix.py -l limited

results in

7 7 6 6 4 tests passed, 0 0 0 0 0 failed

@perrotta
Copy link
Contributor

Ok, this is for 74X,
Make an identical PR for 73X as well.
72X is perhaps too much optimistic...

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 28, 2014

+1

for #6593 b17cb4d

the same as #6595 b17cb4d
tested as a part of #6618 (using 730pre3 as a baseline, in test area sign468
no differences in RECO outputs based on monitored quantities.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 28, 2014
…fixTrackClusterRemover

fix track cluster remover template definition
@cmsbuild cmsbuild merged commit 3e16276 into cms-sw:CMSSW_7_4_X Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants