Guard the nPho histograms from double counting, should fix HI issues #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X. Guard the nPho histograms from double counting, should fix HI issues It involves the following packages: DQMOffline/EGamma @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
ktf
added a commit
that referenced
this pull request
Nov 26, 2014
Guard the nPho histograms from double counting, should fix HI issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HI reco DQM, photons are being double-counted because in HI RECO we do not pre-select at the RECO level for isolated photons. Since most HI photons are not isolated according to the default cuts they have type==0 and get double-counted.
Forward port of #6574 into CMSSW_7_4_X. Will merge automatically since the former is fully signed in CMSSW_7_3_X.