Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display (#6637). #6656

Merged
merged 3 commits into from Jan 6, 2015
Merged

Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display (#6637). #6656

merged 3 commits into from Jan 6, 2015

Conversation

dmitrijus
Copy link
Contributor

No description provided.

Dmitrijus Bugelskis added 3 commits November 27, 2014 12:52
DQM protobuf reads and writes now close the file descriptors properly.
95116d6 
Well, not properly, this is just a quick fix.
We should rewrite and avoid using ::open altogether.

(cherry picked from commit cda6b95)
Fix a minor compilation mistake introduced in the previous commit.
7cd3b2f 
(cherry picked from commit 3b9d0be)
Add JsonWritingTimeoutPoolOutputModule.
bcc4507 
This module adds two additional features (needed for the event display)
to the TimeoutPoolOutputModule:

1. file names now follow the DAQ/online convention (files are named
run0001111_lumi0000_streamLabel_hostname.root);

2. for every file written (and after the file is closed), the json file
containing some metadata is produced. This file signals DAQ
services to start merging/distribution of the .root file.

(cherry picked from commit b2e6c5e)
@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Nov 27, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_3_X.

Forward port of #6570 and #6637 to 73x

It involves the following packages:

DQMServices/Components
DQMServices/Core
DQMServices/StreamerIO
IOPool/Output

@Dr15Jones, @danduggan, @cmsbuild, @nclopezo, @deguio, @ktf can you please review it and eventually sign? Thanks.
@barvic, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Is this needed for 7_3?

@deguio
Copy link
Contributor

deguio commented Nov 27, 2014

+1
@Dr15Jones
probably not. needed in 72 and 74, but it is probably better to keep 73 aligned as well, no?
F.

@cmsbuild
Copy link
Contributor

+1
Tested at: bcc4507
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6656/1205/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@dmitrijus dmitrijus changed the title Forward port of #6570 and #6637 to 73x Forward port of (#6570) Fixes an issue with too many open fds in DQMStore and (#6637) Adds a new output module for evt. display. Jan 6, 2015
@dmitrijus dmitrijus changed the title Forward port of (#6570) Fixes an issue with too many open fds in DQMStore and (#6637) Adds a new output module for evt. display. Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display. (#6637) Jan 6, 2015
@dmitrijus dmitrijus changed the title Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display. (#6637) Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display (#6637). Jan 6, 2015
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 6, 2015
@cmsbuild
Merge pull request #6656 from dmitrijus/closedjson_goes_forward
5e1379d 
Forward port of: Fix an issue with too many open fds in DQMStore (#6570); Add a new output module for evt. display (#6637).
@cmsbuild cmsbuild merged commit 5e1379d into cms-sw:CMSSW_7_3_X Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmitrijus @cmsbuild @Dr15Jones @deguio @davidlange6