migration from EDProducer to stream::EDProducer (BeamSpotOnlineProducer)

[mtosi]

as reported by @fwyzard
https://docs.google.com/spreadsheets/d/1D9khDvOl05WEbznsUPCusEbrHeep9hh8cXedMXX09Gc/edit#gid=0
there are modules used @HLT which still need to be migrated and be multithread safe

this is the migration of the module BeamSpotOnlineProducer

[mtosi]

@cerati @rovere @VinInn

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

migration from EDProducer to stream::EDProducer (BeamSpotOnlineProducer)

It involves the following packages:

RecoVertex/BeamSpotProducer

@nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @StoyanStoynev, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[slava77]

Hi Mia,

Is there any strong reason to make these in separate PRs?
The changes are supposedly equivalent and could be reviewed and tested in one go.
PR integration tests by jenkins tool will have to run n times.
(I myself will just check them all in one go to save time)

If this is the last PR in your series, no need to do anything, but if you have 10 more, it's not the right way.

[mtosi]

ciao
this is the last (-1) from my side
I'm sorry, but I'm always confused on how many PRs I should do when handling different things
I thought that in this way if any issue could have come out, the rest would have been safe

I think I did the same for the DQMHarvesting migration of the tracking DQM ... if I'm not wrong
but ok, next time, in similar conditions, I'll proceed by updating the same PR, thus

sorry the extra work
and thanks for the comment/suggestion

[Dr15Jones]

By the way, I wanted to say "thanks" for making these changes.

[Dr15Jones]

Shouldn't this be a tracked parameter?

[Dr15Jones]

I take that back, it is just used to make the code verbose. Untracked is the proper type.

[cmsbuild]

+1
Tested at: 8225778
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6671/1221/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6671/1221/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6671/1308/summary.html

[slava77]

alca-reco signature is needed here.
@rcastello @diguida please check and sign

[diguida]

+1
Sorry for the long waiting: I was sick in the past weeks.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.