Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hgc clusters electrons #6697

Merged

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Nov 29, 2014

New clustering for HGC photons and electrons, including baseline calibration
@lgray - check carefully i didn't break much of your code
@vandreev11 - follow this PR as well
A photon gun sample produced with this is available in
/store/cmst3/group/hgcal/CMSSW/Single22_CMSSW_6_2_0_SLHC20_new_hgc_clusters_electrons-fullcalib/RECO

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

New hgc clusters electrons

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Nov 29, 2014

@pfs looks fine to me! Could you post a few final plots to this PR?

@pfs
Copy link
Contributor Author

pfs commented Nov 29, 2014

@lgray 3 fast plots for unconverted photons

The efficiency to find a supercluster within R=0.3 (points are photons with matched SC)
sc_efficiency

SC energy response versus photon ET (inclusive in eta)
sc_response_et

SC energy response versus photon eta (inclusive in E)
sc_response_eta

@lgray
Copy link
Contributor

lgray commented Nov 29, 2014

@pfs Scale looks like it has a ~5% shift upwards (the mode of response distribution is above 1.0), but seems uniform in energy/eta. I think this might be due to the calibration methodology, since it relies on means the low side tails can bias the response. We can refine this in time.

Otherwise looks OK to me.

@lgray
Copy link
Contributor

lgray commented Nov 29, 2014

@mark-grimes @vandreev11 Looks like we are ready to go with this one, and the calibration checks out.

Unless there are any disagreements, I'd say we can merge and cut the release. Apologies for the delay.

@salerno Can you take this branch and give a look to the electron efficiency with the appropriate calibration?

@fratnikov
Copy link

@lgray Is it OK that in RecoParticleFlow/PFClusterProducer/python/particleFlowClusterHGCEE_cfi.py
_HGCEE_HADEnergyCalibrator defines weights_ee and weights_he, while _HGCEE_EMEnergyCalibrator uses weights_ee, weights_hef, weights_heb?
They both use the same calibrator HGCAllLayersEnergyCalibrator, and this calibrator
https://github.com/PFCal-dev/cmssw/blob/new_hgc_clusters_electrons/RecoParticleFlow/PFClusterProducer/src/HGCAllLayersEnergyCalculator.cc#L24
does require HEF and HEB weights separately...

@lgray
Copy link
Contributor

lgray commented Nov 29, 2014

@fratnikov Since the former is not used it's OK, this will of course be updated in the branch where hadron clustering is being worked on.

@mark-grimes
Copy link

merge

I tested privately and all is fine, cms-bot has been playing up recently for SLHC.

cmsbuild added a commit that referenced this pull request Nov 30, 2014
@cmsbuild cmsbuild merged commit 392d0f1 into cms-sw:CMSSW_6_2_X_SLHC Nov 30, 2014
@pfs pfs deleted the new_hgc_clusters_electrons branch November 18, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants