New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hgc clusters electrons #6697
New hgc clusters electrons #6697
Conversation
A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC. New hgc clusters electrons It involves the following packages: RecoParticleFlow/PFClusterProducer @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@pfs looks fine to me! Could you post a few final plots to this PR? |
@lgray 3 fast plots for unconverted photons The efficiency to find a supercluster within R=0.3 (points are photons with matched SC) |
@pfs Scale looks like it has a ~5% shift upwards (the mode of response distribution is above 1.0), but seems uniform in energy/eta. I think this might be due to the calibration methodology, since it relies on means the low side tails can bias the response. We can refine this in time. Otherwise looks OK to me. |
@mark-grimes @vandreev11 Looks like we are ready to go with this one, and the calibration checks out. Unless there are any disagreements, I'd say we can merge and cut the release. Apologies for the delay. @salerno Can you take this branch and give a look to the electron efficiency with the appropriate calibration? |
@lgray Is it OK that in RecoParticleFlow/PFClusterProducer/python/particleFlowClusterHGCEE_cfi.py |
@fratnikov Since the former is not used it's OK, this will of course be updated in the branch where hadron clustering is being worked on. |
merge I tested privately and all is fine, cms-bot has been playing up recently for SLHC. |
New clustering for HGC photons and electrons, including baseline calibration
@lgray - check carefully i didn't break much of your code
@vandreev11 - follow this PR as well
A photon gun sample produced with this is available in
/store/cmst3/group/hgcal/CMSSW/Single22_CMSSW_6_2_0_SLHC20_new_hgc_clusters_electrons-fullcalib/RECO