Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gem06 #6708

Merged
merged 2 commits into from Dec 3, 2014
Merged

Phase2-gem06 #6708

merged 2 commits into from Dec 3, 2014

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 1, 2014

Update GEM geometry and put in the latest changes needed after orientation and z-position issues.
Also transfer all PhaseII files from SLHC branch

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2014

A new Pull Request was created by @bsunanda for CMSSW_7_4_X.

Phase2-gem06

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ianna
Copy link
Contributor

ianna commented Dec 2, 2014

-1

@bsunanda - as requested by @davidlange6 xml files defining 2015 scenario should not be touched. There is a new scenario for development 2015dev defined in #6512 PR. All 2015 further changes and bug-fixes should go there.

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 2, 2014

Please let me know which xml files you are referring to which need not be touched. I touched a few files because the context was wrong (the content otherwise was not modified).


From: Ianna Osborne [notifications@github.com]
Sent: 02 December 2014 10:18
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Phase2-gem06 (#6708)

-1

@bsunandahttps://github.com/bsunanda - as requested by @davidlange6https://github.com/davidlange6 xml files defining 2015 scenario should not be touched. There is a new scenario for development 2015dev defined in #6512#6512 PR. All 2015 further changes and bug-fixes should go there.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6708#issuecomment-65202147.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

Pull request #6708 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@ianna
Copy link
Contributor

ianna commented Dec 3, 2014

+1

@bsunanda - Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 3, 2014
@cmsbuild cmsbuild merged commit 8237960 into cms-sw:CMSSW_7_4_X Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants