Find indirect data members #6730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X. Find indirect data members It involves the following packages: FWCore/Utilities @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
core-approved
fully-signed
tests-pending
and removed
comparison-pending
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_ROOT6_X IBs unless changes or unless it breaks tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the testNamedReference unit test in CondCore/ORA. The problem was that TypeWithDict::dataMemberByName(name) would find only direct data members of a class.
This function was enhanced to also find indirect data members.
Also, I noticed that the default ctor of MemberWithDict() did not explicitly initialize its data member, a pointer. So this request also explicitly initializes the pointer.
Please merge as soon as convenient.