Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel DQM code: geometry-independent redesign #6731

Merged

Conversation

friccita
Copy link
Contributor

@friccita friccita commented Dec 1, 2014

Combined geometry-independent modifications from P. Cirkovic, D. Devetak, and F. Ricci-Tam to DQM/SiPixel* folders

  • using the TrackerTopology class, all instances of the classes PixelBarrelNameUpgrade and PixelEndcapNameUpgrade have been replaced with PixelBarrelName and PixelEndcapName
  • several MonitorElements have been replaced by vectors of MonitorElements, whose size depends on whether Phase0/1 geometry is being used

cirkovic and others added 30 commits October 19, 2014 17:55
…d in the SiPixelClusterSource and SiPixelClusterModule class, by replacing the scalar type of the monitor elements variables with their vector type.
…xelBarrelName and PixelBarrelNameUpgrade which require checking the isUpgrade flag in the code.
…ional 'if (isUpgrade)' statements for purposes of determining if PixelBarrelName or PixelBarrelNameUpgrade is used.
…-10-28-0200_28-10-2014' into from-CMSSW_7_3_X_2014-10-29-0200
…_29-10-2014' into from-CMSSW_7_3_X_2014-10-31-0200_31-10-2014
…lient) modified to accept the PixelBarrelName and PixelEndcapName wrapper classes.
…_31-10-2014' into from-CMSSW_7_3_X_2014-11-07-0200_07-11-2014
…_29-10-2014' into from-CMSSW_7_3_X_2014-11-11-0200
…-0200_1' into from-CMSSW_7_3_X_2014-11-30-0200
@nclopezo
Copy link
Contributor

nclopezo commented Dec 2, 2014

Actually, it can be merged now. It seems that github was still showing the previous state.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

@deguio
Copy link
Contributor

deguio commented Dec 5, 2014

+1
@friccita please rename this PR with a meaningful title for future reference.
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 5, 2014
@cmsbuild cmsbuild merged commit 0467e31 into cms-sw:CMSSW_7_4_X Dec 5, 2014
@friccita friccita changed the title From cmssw 7 3 x 2014 11 30 0200 Pixel DQM code: geometry-independent redesign Dec 5, 2014
cirkovic added a commit to cirkovic/cmssw that referenced this pull request Feb 19, 2015
Fixing 'for' loops in SiPixelClusterModule::fill() and SiPixelTrackResidualSource::analyze() with DBlayer and DBdisk.
cmsbuild added a commit that referenced this pull request Feb 23, 2015
cmsbuild added a commit that referenced this pull request Feb 24, 2015
cirkovic added a commit to cirkovic/cmssw that referenced this pull request Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants