Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in PFJetID calculation due to change in PFJet fraction calculation #6744

Merged
merged 1 commit into from Dec 3, 2014

Conversation

webermat
Copy link
Contributor

@webermat webermat commented Dec 2, 2014

In 7_3_0_pre1 the PFJet Fractions changed, from then on the NeutralHadronEnergy is the sum of the former NeutralHadronEnergy+HFHadronEnergy; same holds for the NeutralHadronEnergyFraction.

The PFJetIDSelectionFunctor has been now updated to accomodate this feature. The effects are especially prominent if we compare MiniAOD with RECO, since the calculation of the PFJetID is done in slightly different ways, more details can be found in
https://indico.cern.ch/event/294180/contribution/4/material/slides/0.pdf

slide 9 before the fix.
slide 11 illustrates the feature
slide 12 shows the expected agreement between RECO and MiniAOD formats, and the expected increase of the passFraction for forward Jets.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

A new Pull Request was created by @webermat for CMSSW_7_4_X.

fix in PFJetID calculation due to change in PFJet fraction calculation

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@vadler
Copy link

vadler commented Dec 3, 2014

+1
Tested with CMSSW_7_4_X_2014-12-03-0200.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 3, 2014
fix in PFJetID calculation due to change in PFJet fraction calculation
@cmsbuild cmsbuild merged commit 72fe2b8 into cms-sw:CMSSW_7_4_X Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants