combine all test plugins in to one #6756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we need all these separate plugins or can live with one?
One problem here is that each of these plugins use ../src/CSCMap1.cc file and generate
tmp_path/pluginnameX/../src/CSCMap1.o
so basically the output object file for all these are same which can cause problem while compiler with -j n.
If having separate plugins is required then we can do something like
<library name="CSCMap1" file="../src/CSCMap1.cc"/>
and then link it in each plugin but I would prefer to have one plugin.