Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine all test plugins in to one #6756

Merged
merged 1 commit into from Dec 3, 2014
Merged

combine all test plugins in to one #6756

merged 1 commit into from Dec 3, 2014

Conversation

smuzaffar
Copy link
Contributor

Do we need all these separate plugins or can live with one?
One problem here is that each of these plugins use ../src/CSCMap1.cc file and generate
tmp_path/pluginnameX/../src/CSCMap1.o
so basically the output object file for all these are same which can cause problem while compiler with -j n.

If having separate plugins is required then we can do something like
<library name="CSCMap1" file="../src/CSCMap1.cc"/>

and then link it in each plugin but I would prefer to have one plugin.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_4_X.

combine all test plugins in to one

It involves the following packages:

OnlineDB/CSCCondDB

@ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

@apfeiffer1
Copy link
Contributor

+1
looks OK to me - I don't think the testing will see an issue with a single plugin instead of individual ones.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 3, 2014
@cmsbuild cmsbuild merged commit e7efd65 into cms-sw:CMSSW_7_4_X Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants