Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of VertexFromTrackProducer module #6759

Merged
merged 1 commit into from Dec 3, 2014
Merged

Fix of VertexFromTrackProducer module #6759

merged 1 commit into from Dec 3, 2014

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Dec 3, 2014

This is a small fix to VertexFromTrackProducer module used at HLT, namely an unused data member and corresponiding getter are removed.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 3, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

A new Pull Request was created by @mbluj for CMSSW_7_4_X.

Fix of VertexFromTrackProducer module

It involves the following packages:

RecoTauTag/HLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Martin-Grunewald
Copy link
Contributor

Could you update the 73X PR #6686 with that as well?

@mbluj
Copy link
Contributor Author

mbluj commented Dec 3, 2014

73X PR #6686 updated with this PR and other cleaning fixes from #6713

@mbluj mbluj mentioned this pull request Dec 3, 2014
Merged
@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

+1
Tested at: dd4a661
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6759/1410/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 3, 2014
@cmsbuild
Merge pull request #6759 from mbluj/VertexFromTrackProducer_fix_74X
8f95c3e 
Fix of VertexFromTrackProducer module
@cmsbuild cmsbuild merged commit 8f95c3e into cms-sw:CMSSW_7_4_X Dec 3, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6759/1410/summary.html

@mbluj mbluj deleted the VertexFromTrackProducer_fix_74X branch September 7, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbluj @cmsbuild @Martin-Grunewald