Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended_DIGI_window #6777

Merged
merged 1 commit into from Dec 12, 2014
Merged

Conversation

amartelli
Copy link
Contributor

extended ECAL digitization window

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

A new Pull Request was created by @amartelli for CMSSW_7_4_X.

extended_DIGI_window

It involves the following packages:

SimCalorimetry/EcalSimAlgos

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

@davidlange6
Copy link
Contributor

73x and 74x are nominally both closed to digi changes now. Is there a discussion of this request somewhere?

On Dec 4, 2014, at 10:01 AM, amartelli notifications@github.com
wrote:

extended ECAL digitization window

You can merge this Pull Request by running

git pull https://github.com/amartelli/cmssw extended_DIGI_window
Or view, comment on, or merge it at:

#6777

Commit Summary

• extended_DIGI_window
File Changes

• M SimCalorimetry/EcalSimAlgos/src/EcalHitResponse.cc (2)
Patch Links:

https://github.com/cms-sw/cmssw/pull/6777.patch
https://github.com/cms-sw/cmssw/pull/6777.diff

Reply to this email directly or view it on GitHub.

@amartelli
Copy link
Contributor Author

These requests are to fix the ECAL digi window to account for the one used in the mixing. It is important to include it in the coming 73X production.

@amartelli
Copy link
Contributor Author

To proceed further and have these included, should a dedicated discussion be opened somewhere else?

@mdhildreth
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 12, 2014
@cmsbuild cmsbuild merged commit 5666ff6 into cms-sw:CMSSW_7_4_X Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants