Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for icc compiler: added the missing pat:: namespace #6779

Merged
merged 1 commit into from Dec 4, 2014
Merged

fix for icc compiler: added the missing pat:: namespace #6779

merged 1 commit into from Dec 4, 2014

Conversation

smuzaffar
Copy link
Contributor

This should fix the following compilation errors for ICC builds
DataFormats/PatCandidates/interface/Jet.h(482): error: no instance of overloaded function "reco::operator<<" matches the specified type friend std::ostream& reco::operator<<(std::ostream& out, const Jet& obj);
DataFormats/PatCandidates/interface/Muon.h(238): error: no instance of overloaded function "reco::operator<<" matches the specified type friend std::ostream& reco::operator<<(std::ostream& out, const Muon& obj);

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_4_X.

fix for icc compiler: added the missing pat:: namespace

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vadler
Copy link

vadler commented Dec 4, 2014

+1
Trivial technical fix.
The implementation is in line with other PAT objects now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 4, 2014
fix for icc compiler: added the missing pat:: namespace
@cmsbuild cmsbuild merged commit e89763a into cms-sw:CMSSW_7_4_X Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants