Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle case where default number of threads requested #6786

Merged
merged 1 commit into from Dec 4, 2014
Merged

Properly handle case where default number of threads requested #6786

merged 1 commit into from Dec 4, 2014

Conversation

Dr15Jones
Copy link
Contributor

If a user requests the default number of threads by specifying '0' as the threads number, be sure to propagate the actual number of threads chosen by TBB to the rest of the system.

@Dr15Jones
Properly handle case where default number of threads requested
3369bcc 
If a user requests the default number of threads by specifying '0' as the threads number, be sure to propagate the actual number of threads chosen by TBB to the rest of the system.
@Dr15Jones
Copy link
Contributor Author

@fwyzard I finally got this done.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Properly handle case where default number of threads requested

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

+1
Tested at: 3369bcc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6786/1434/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 4, 2014
@cmsbuild
Merge pull request #6786 from Dr15Jones/recordNumThreadsIfDefaultUsed
1d423bc 
Properly handle case where default number of threads requested
@cmsbuild cmsbuild merged commit 1d423bc into cms-sw:CMSSW_7_4_X Dec 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6786/1434/summary.html

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6786/1434/summary.html

@Dr15Jones Dr15Jones deleted the recordNumThreadsIfDefaultUsed branch December 8, 2014 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dr15Jones @cmsbuild