Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service callback with path and consumes info #6845

Merged
merged 1 commit into from Dec 12, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Dec 9, 2014

Add new callback that services can register for
that will deliver information about the paths,
end paths, and modules on them. It will also deliver
information about the dependencies between modules
in the current process based on the consumes information.
It also makes available the information in the
consumes declarations. Also includes a new configuration
option to the Tracer that will dump this information
and the Tracer code is an example of how a service
accesses this information. New and expanded unit
tests included.

Add new callback that services can register for
that will deliver information about the paths,
end paths, and modules on them. It will also deliver
information about the dependencies between modules
in the current process based on the consumes information.
It also makes available the information in the
consumes declarations. Also includes a new configuration
option to the Tracer that will dump this information
and the Tracer code is an example of how a service
accesses this information. New and expanded unit
tests included.
@Dr15Jones
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

@fwyzard Hopefully this will prove useful to you

@wddgit
Copy link
Contributor Author

wddgit commented Dec 9, 2014

@fwyzard I tried to make this function give you the information I thought you really wanted modulesWhoseProductsAreConsumedBy. So I would suggest looking there first. There are some comments in the base class header file. Plus there are other functions that give other information.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 9, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

-1

Tested at: 3d846b2
I ran the usual tests and I found errors in the following unit tests:

---> test TestRunnerPhysicsToolsCondLiteIO had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6845/1533/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

@Dr15Jones
Copy link
Contributor

@cmsbuild please retest. I believe this was a transient failure.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

@davidlange6
Copy link
Contributor

@cmsbuild - please rerun the tests

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Dec 12, 2014
Add service callback with path and consumes info
@cmsbuild cmsbuild merged commit 17b2bbd into cms-sw:CMSSW_7_4_X Dec 12, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants