Fix duplicate definitions in ROOT macros #6853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_ROOT6_X. Fix duplicate definitions in ROOT macros It involves the following packages: DataFormats/FWLite @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
nclopezo
added a commit
that referenced
this pull request
Dec 10, 2014
Fix duplicate definitions in ROOT macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request affects only unit tests, and only those in packge DataFormats/FWLite.
The unit tests fails in ROOT6 (among other reasons) due to duplicate definitions of variables. In ROOT5, the tests do not fail, because CINT, unlike cling, is not a real compiler, and is permissive of these errors.
This pull request fixes the macros so that each variable is defined only once.
Please merge this request as soon as convenient.