Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CVS Keywords from Dataformats #687

Merged

Conversation

nclopezo
Copy link
Contributor

@nclopezo nclopezo commented Sep 2, 2013

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X.

Remove CVS Keywords from Dataformats

It involves the following packages:

DataFormats/EcalDigi
DataFormats/Luminosity
DataFormats/HepMCCandidate
DataFormats/EcalRawData
DataFormats/EgammaCandidates
DataFormats/CastorReco
DataFormats/TrackingSeed
DataFormats/DTRecHit
DataFormats/MuonDetId
DataFormats/TrackReco
DataFormats/PatCandidates
DataFormats/HcalDigi
DataFormats/TrackingRecHit
DataFormats/MuonSeed
DataFormats/VertexReco
DataFormats/CSCRecHit
DataFormats/HLTReco
DataFormats/RPCRecHit
DataFormats/SiStripDetId
DataFormats/TrackerCommon
DataFormats/L1Trigger
DataFormats/SiStripCommon
DataFormats/JetReco
DataFormats/CSCDigi
DataFormats/CaloRecHit
DataFormats/L1GlobalMuonTrigger
DataFormats/FEDRawData
DataFormats/LTCDigi
DataFormats/DTDigi
DataFormats/MuonData
DataFormats/GeometrySurface
DataFormats/HcalDetId
DataFormats/RecoCandidate
DataFormats/Alignment
DataFormats/EcalDetId
DataFormats/Histograms
DataFormats/Math
DataFormats/GEMDigi
DataFormats/CaloTowers
DataFormats/Scalers
DataFormats/HeavyIonEvent
DataFormats/EgammaReco
DataFormats/L1GlobalTrigger
DataFormats/EcalRecHit
DataFormats/L1CaloTrigger
DataFormats/RPCDigi
DataFormats/Candidate
DataFormats/GEMRecHit
DataFormats/METReco
DataFormats/EgammaTrackReco
DataFormats/DetId
DataFormats/HcalRecHit
DataFormats/BeamSpot
DataFormats/MuonReco

@vciulli, @perrotta, @civanch, @Dr15Jones, @giamman, @demattia, @fwyzard, @emeschi, @ianna, @rovere, @ktf, @Martin-Grunewald, @thspeer, @mdhildred, @deguio, @slava77, @mommsen, @vadler, @mulhearn, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor Author

nclopezo commented Sep 2, 2013

Hi,

I tested if it compiles and it does, you can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/351/consoleFull

@@ -1,11 +1,9 @@
#ifndef DataFormats_Alignment_TkFittedLasBeam_h
#define DataFormats_Alignment_TkFittedLasBeam_h

/// \class TkFittedLasBeam ($Revision: 1.3 $)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful for doxygen to keep the \class TkFittedLasBeam

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

Pull request #687 was updated. Signatures reset, please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

Pull request #687 was updated. Signatures reset, please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

The following categories have been signed by meschi (a.k.a. @emeschi on GitHub): DAQ

@cms-git-daq

@Dr15Jones
Copy link
Contributor

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Sep 2, 2013

+1

@thspeer
Copy link
Contributor

thspeer commented Sep 3, 2013

+1
Tested 6dca1b8 in CMSSW_7_0_X_2013-09-02-0200-687

@nclopezo
Copy link
Contributor Author

nclopezo commented Sep 3, 2013

All the changes are in the comments, I checked that It compiles. I will bypass the rest of the signatures.

nclopezo added a commit that referenced this pull request Sep 3, 2013
…rmats

Remove CVS Keywords from Dataformats
@nclopezo nclopezo merged commit cb6cdfb into cms-sw:CMSSW_7_0_X Sep 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants