Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce HGC rechit memory footprint #6893

Merged
merged 3 commits into from Dec 15, 2014
Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Dec 12, 2014

Remove a merging module that is un-necessary, should reduce HGC rechit memory footprint by 2x.

Trying to get a working rechit creator that can service all three HGC subcomponents at once, removing the need for a merging module. For some reason it will not let any rechits pass. I working on a fix since this is necessary to keep the memory use down once we start collection rechits in the whole detector at once.

This is a decent patch for now since the subcomponents are clustered separately in this version of HGC RECO.

Last commit should help reduce the retained memory by quite a bit.

@pfs @vandreev11

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Reduce HGC rechit memory footprint

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Currently get

RecoParticleFlow/PFClusterProducer/src/Navigators.cc:14:77: fatal error: RecoParticleFlow/PFClusterProducer/interface/HGCRecHitNavigator.h: No such file or directory

Could you add this file?

@lgray
Copy link
Contributor Author

lgray commented Dec 12, 2014

Ah, should have been removed from the .cc I'll add it, just a second.

@lgray
Copy link
Contributor Author

lgray commented Dec 12, 2014

there you go.

@cmsbuild
Copy link
Contributor

Pull request #6893 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again.

@mark-grimes
Copy link

merge

All tests fine, haven't checked memory use yet though. @boudoul, there will be some memory improvement in the next release in case you want to try HGCal relvals again.

cmsbuild added a commit that referenced this pull request Dec 15, 2014
Reduce HGC rechit memory footprint
@cmsbuild cmsbuild merged commit ae8db5a into cms-sw:CMSSW_6_2_X_SLHC Dec 15, 2014
@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor Author

lgray commented Dec 15, 2014

@mark-grimes if you've got a script, config, and file I can use to make a realistic test please send by email and I'll check the memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants