Remove unnecessary type info calls

[wmtan]

This pull request has two purposes:

1. In ROOT6, ROOT does not provide type_info information for non-class types, such as enums, pointers, and C-Style arrays. This currently can cause TypeWithDict::typeInfo() to return incorrect information in the ROOT6 IB. The first step to fixing this problem is to remove unnecessary calls to TypeWithDict::typeInfo(). This pull request does this in the framework and in
   CommonTools/Utils/src/AnyMethodArgument.h. Since the changed code works equally well in ROOT5, this is being requested in the main 7_4_X branch (ROOT5) for code commonality.

2. I happened to notice that I had extensively edited several other source files in ComonTools/Utils in the ROOT6 branch to make them more readable (non-substantive formatting changes). These changes should have been made in the main branch as well for code commonality. This pull request makes the same changes in the main 7_4_X branch for code commonality with the ROOT6 IB. All the changes in CommonTools/Utils, except for those in AnyMethodArgument.h, are essentially no-ops.

All unit tests in the affected packages pass and the short relval matrix tests still pass with these changes.

I request that this pull request not be merged into the 7_4_X_ROOT6 branch, because these changes will be made there independently. This is not critical, because I can clean things up if merging this causes any problems in the 7_4_X_ROOT6 branch.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Remove unnecessary type info calls

It involves the following packages:

CommonTools/Utils
DataFormats/Common
FWCore/Framework
FWCore/Modules
FWCore/Utilities
IOPool/Input

@nclopezo, @monttj, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @ktf can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[wmtan]

I request that this pull request not be merged into the 7_4_X_ROOT6 branch, because these changes will be made there independently. This is not critical, because I can clean things up if merging this causes any problems in the 7_4_X_ROOT6 branch.

[Dr15Jones]

+1

[cmsbuild]

+1
Tested at: aba1bb9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6896/1594/summary.html

[davidlange6]

@ktf - is this hold still needed?

[ktf]

#7013 takes care of not merging this in ROOT6_X. Hold can go. I'll also bypass the analysis signature.