Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to compute ES cluster shapes #6918

Merged

Conversation

matteosan1
Copy link
Contributor

Bug fix to EcalClusterTools to compute Preshower cluster shapes. Same as #6917 but for 73X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_3_X.

bug fix to compute ES cluster shapes

It involves the following packages:

RecoEcal/EgammaCoreTools

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Dec 15, 2014

Does this add functionality or fix methods that are not used in standard reco sequences?
If the physics output of standard sequences changes, some more details are needed.

@matteosan1
Copy link
Contributor Author

Hi Slava,
it just (re)allow to compute ES cluster shapes which are not normally
used in standard reco sequences.

On 12/15/14 14:49, Slava Krutelyov wrote:

Does this add functionality or fix methods that are not used in
standard reco sequences?
If the physics output of standard sequences changes, some more details
are needed.


Reply to this email directly or view it on GitHub
#6918 (comment).

+++++++++++
Matteo Sani
University of California, San Diego, US.
Tel: +41227671577
CERN Office: 40-3-A02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 45f94e3.
Identical to #6919 (for 74X) which was signed off. Jenkins here are also fine and in fact show no false positives which were seen in #6919.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants