73X: L1REPACK for HLT and fixes

[Martin-Grunewald]

73X: L1REPACK for HLT and fixes
Backport of #6979 including also #6847 except for the HI menu itself which is in #6960

[cmsbuild]

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_3_X.

73X: L1REPACK for HLT and fixes

It involves the following packages:

Configuration/Applications
Configuration/StandardSequences
HLTrigger/Configuration
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
SLHCUpgradeSimulations/Configuration

@perrotta, @cmsbuild, @civanch, @nclopezo, @mdhildreth, @Martin-Grunewald, @franzoni, @fwyzard, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @jalimena, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

Pull request #6980 was updated. @perrotta, @cmsbuild, @civanch, @nclopezo, @mdhildreth, @Martin-Grunewald, @franzoni, @fwyzard, @mulhearn, @davidlange6 can you please check and sign again.

[Martin-Grunewald]

Kick @cmsbuild

[Martin-Grunewald]

Can we please move on this PR?

[ktf]

+1

[ktf]

@mulhearn @davidlange6 waiting for you...

[davidlange6]

i was trying to convince myself that nothing in prod gets changed by this PR, but I didn't manage yet… will try again later.

On Jan 9, 2015, at 4:05 PM, Giulio Eulisse notifications@github.com
wrote:

@mulhearn @davidlange6 waiting for you...

—
Reply to this email directly or view it on GitHub.

[davidlange6]

Hi Martin, Mike, all

I'm down to one line:

--- a/L1Trigger/L1TCommon/python/customsPostLS1.py
+++ b/L1Trigger/L1TCommon/python/customsPostLS1.py
@@ -30,6 +30,11 @@ def customiseSimL1EmulatorForPostLS1(process):
process.gctDigiToRaw.gctInputLabel = 'simCaloStage1LegacyFormatDigis'

 if hasattr(process, 'simGctDigis'):

•    for sequence in process.sequences:
  

•        #print "INFO:  checking sequence ", sequence
  

•        #print "BEFORE:  ", getattr(process,sequence)
  

•        getattr(process,sequence).replace(process.simGctDigis,process.L1TCaloStage1)
  

•        #print "AFTER:  ", getattr(process,sequence)
  

could you summarize what this is doing?

Cheers-
David

On Jan 9, 2015, at 4:07 PM, David Lange David.Lange@cern.ch wrote:

i was trying to convince myself that nothing in prod gets changed by this PR, but I didn't manage yet… will try again later.

On Jan 9, 2015, at 4:05 PM, Giulio Eulisse notifications@github.com
wrote:

@mulhearn @davidlange6 waiting for you...

—
Reply to this email directly or view it on GitHub.

[mulhearn]

Sorry, was AWOL: 2 jet lagged babies, start of new quarter, and no
internet at home...

This is replacing the legacy GCT step with the post LS1 step in all
sequences.

-Mike

On Sat, Jan 10, 2015 at 2:59 AM, David Lange notifications@github.com
wrote:

Hi Martin, Mike, all

I'm down to one line:

--- a/L1Trigger/L1TCommon/python/customsPostLS1.py
+++ b/L1Trigger/L1TCommon/python/customsPostLS1.py
@@ -30,6 +30,11 @@ def customiseSimL1EmulatorForPostLS1(process):
process.gctDigiToRaw.gctInputLabel = 'simCaloStage1LegacyFormatDigis'

if hasattr(process, 'simGctDigis'):

• for sequence in process.sequences:
• #print "INFO: checking sequence ", sequence
• #print "BEFORE: ", getattr(process,sequence)
  +
  getattr(process,sequence).replace(process.simGctDigis,process.L1TCaloStage1)
• #print "AFTER: ", getattr(process,sequence)

could you summarize what this is doing?

Cheers-
David

On Jan 9, 2015, at 4:07 PM, David Lange David.Lange@cern.ch wrote:

i was trying to convince myself that nothing in prod gets changed by
this PR, but I didn't manage yet… will try again later.

On Jan 9, 2015, at 4:05 PM, Giulio Eulisse notifications@github.com
wrote:

@mulhearn @davidlange6 waiting for you...

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#6980 (comment).

[Martin-Grunewald]

Hi,

This used to be run only for paths, which means sequences in paths
containing the module were expanded (modules put directly into the
path and the intermediate sequence definition removed). This way the
sequences themselves are kept and can thus be used in further
manupulations.

Best regards

Martin

On Sat, 10 Jan 2015, mulhearn wrote:

Sorry, was AWOL: 2 jet lagged babies, start of new quarter, and no
internet at home...

This is replacing the legacy GCT step with the post LS1 step in all
sequences.

-Mike

On Sat, Jan 10, 2015 at 2:59 AM, David Lange notifications@github.com
wrote:

Hi Martin, Mike, all

I'm down to one line:

--- a/L1Trigger/L1TCommon/python/customsPostLS1.py
+++ b/L1Trigger/L1TCommon/python/customsPostLS1.py
@@ -30,6 +30,11 @@ def customiseSimL1EmulatorForPostLS1(process):
process.gctDigiToRaw.gctInputLabel = 'simCaloStage1LegacyFormatDigis'

if hasattr(process, 'simGctDigis'):

• for sequence in process.sequences:
• #print "INFO: checking sequence ", sequence
• #print "BEFORE: ", getattr(process,sequence)
  +
  getattr(process,sequence).replace(process.simGctDigis,process.L1TCaloStage1)
• #print "AFTER: ", getattr(process,sequence)

could you summarize what this is doing?

Cheers-
David

On Jan 9, 2015, at 4:07 PM, David Lange David.Lange@cern.ch wrote:

i was trying to convince myself that nothing in prod gets changed by
this PR, but I didn't manage yet… will try again later.

On Jan 9, 2015, at 4:05 PM, Giulio Eulisse notifications@github.com
wrote:

@mulhearn @davidlange6 waiting for you...

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#6980 (comment).

---

Reply to this email directly or view it on GitHub:
#6980 (comment)

Martin

Martin W. Gruenewald e-mail: Martin.Grunewald@cern.ch
http://cern.ch/Martin.Grunewald

[davidlange6]

@Martin-Grunewald - I see now. Thanks - I can confirm we don't get any (real) changes to the config