Upgraded a bunch of modules in DQM/Physics to the new interface #6986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @vanbesien (Broen van Besien) for CMSSW_7_4_X. Upgraded a bunch of modules in DQM/Physics to the new interface It involves the following packages: DQM/Physics @cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
cmsbuild
added a commit
that referenced
this pull request
Jan 6, 2015
Upgraded a bunch of modules in DQM/Physics to the new interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7 modules in DQM/Physics that still needed to be upgraded.
Nothing special to report, it compiles and runTheMatrix -l 20.0 ran fine.
Some of the classes had a bit more complex structure, but nothing extraordinary.
DQM/Physics/src/SusyDQM.h was a bit special since it's all templated and the content you would expect in the cc files was all just added to the header file. I guess the person who wrote this might have had a reason for this, probably because of the templates, so I didn't change it.