add MET receipe #6994
add MET receipe #6994
Conversation
|
A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_5_3_X. add MET receipe It involves the following packages: DataFormats/METReco @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please review it and eventually sign? Thanks. |
|
It would help to rebase on top of the latest release/IB in 53X. the first commit on the list is in 53X since Feb, with #2402 |
|
about |
| significance=0.; | ||
| CorrMETData(const CorrMETData& corr) : mex(corr.mex), mey(corr.mey), sumet(corr.sumet), significance(corr.significance) { } | ||
|
|
||
| CorrMETData& operator+=(const CorrMETData& rhs) |
There was a problem hiding this comment.
these have a pretty long history
https://hypernews.cern.ch/HyperNews/CMS/get/pkgAnnounce/137777.html
We've integrated quite a bit of analysis level code in 53X since then; I guess that was a bad timing back in Feb 2013.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf |
|
+1 |
|
This PR has been merged. But I will write the answer to the question about these two files for the record. These two files were originally merged to CMSSW_6_2_0_pre5. The addition of these two files were published in CmsTC and approved in March 2013. This was the task generalize MET correction (1st step) described on CMS.METDevelopmentPlan. Later in CMSSW_7_0_0_pre11, these two files were renamed respectively with the PR #1823. This PR used the original names because this branch has been being used by many users and renaming them would break many configuration files already being used. |
The MET group is planning to close the MET recipe by integrating it into either the CMSSW releases or the PAT recipes [https://github.com/cms-met/issues/1].
This PR contains the commits in the current MET recipe. With this PR in the CMSSW, we can close the MET recipe for 5_3_X.
The commit TaiSakuma@ac3814e?diff=split edits a file under DataFormats/METReco but doesn't change the data format. It only adds friend operators and won't require to update the checksum. I am not sure if that is ok.