New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in event filtering #7026
Conversation
osschar
commented
Dec 30, 2014
- Fireworks/Core/interface/FWRepresentationInfo.h
- Initialize m_requiresFF in full ctor.
- Fireworks/Core/src/FWFileEntry.cc
- Use proper edm::Wrapper typeid when asking fwlite::Event for branch name (by Chris). This fixes a bug that basically made event content and navigation random after one tried to enable filters.
- Cleanup surrounding code:
- Use a map to store previous branch addresses.
- Only do branch-name query and regex_replace for matching collections.
… name (by Chris). This fixes a bug that basically made event content and navigation random after one tried to enable filters. * Cleanup surrounding code: - Use a map to store previous branch addresses. - Only do branch-name query and regex_replace for matching collections.
+1 |
A new Pull Request was created by @osschar (Matevž Tadel) for CMSSW_7_3_X. Bugfix in event filtering It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |