Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal v6 hesci geometry modif #7040

Merged

Conversation

vandreev11
Copy link
Contributor

@bsunanda, @pfs, @lgray To modify HGCAL V6 HEscintillator dimensions to be in agreement with TC drawings, on top of V6 HEsilicon geometry modification

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2015

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

Hgcal v6 hesci geometry modif

It involves the following packages:

Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Jan 4, 2015

please test
On dom 4 gen 2015 at 09:30 cmsbuild notifications@github.com wrote:

A new Pull Request was created by @vandreev11
https://github.com/vandreev11 for CMSSW_6_2_X_SLHC.

Hgcal v6 hesci geometry modif

It involves the following packages:

Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData

@civanch https://github.com/civanch, @Dr15Jones
https://github.com/Dr15Jones, @ianna https://github.com/ianna,
@mdhildreth https://github.com/mdhildreth, @cmsbuild
https://github.com/cmsbuild, @nclopezo https://github.com/nclopezo,
@ktf https://github.com/ktf can you please review it and eventually
sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@fratnikov https://github.com/fratnikov, @mark-grimes
https://github.com/mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#7040 (comment).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2015

The tests are being triggered in jenkins.

@pfs
Copy link
Contributor

pfs commented Jan 4, 2015

@vandreev11 Just to confirm : HEsil is the HErebuild version introduced by @bsunanda?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2015

@vandreev11
Copy link
Contributor Author

@pfs Yes, it is V6 HEsil, means HErebuild introduced by @bsunanda.

@vandreev11
Copy link
Contributor Author

@pfs, @bsunanda Once more, to be precise. It is V6 HEsci as HErebuild, while V6 HEsil is modified V5 HEsil to have flat end for cooling manifolds. Two subdetectors have been modified.

@mark-grimes
Copy link

Is Geometry/HcalCommonData/data/PhaseII/HGCal/hcalendcapalgo.xml only used by V6?

@vandreev11
Copy link
Contributor Author

@mark-grimes Yes, it is.

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Jan 6, 2015
@cmsbuild cmsbuild merged commit cc25ce3 into cms-sw:CMSSW_6_2_X_SLHC Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants