Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forcing full declaration of HEScintillator as HE rebuild SD #7046

Merged
merged 1 commit into from Jan 6, 2015

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Jan 6, 2015

@bsunanda @vandreev11 In principle this resolves the ambiguity between HEScintillator (HE-rebuild) and HESilicon (HGC-FH) when declaring these as sensitive detectors. HCAL experts should comment if this breaks anything. In the generation of events I observe HGCHESiliconHits and also HcalHits.
@lgray fyi

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2015

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

forcing full declaration of HEScintillator as HE rebuild SD

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested privately, all fine.

cmsbuild added a commit that referenced this pull request Jan 6, 2015
forcing full declaration of HEScintillator as HE rebuild SD
@cmsbuild cmsbuild merged commit d25c07e into cms-sw:CMSSW_6_2_X_SLHC Jan 6, 2015
@pfs pfs deleted the hgcv6_sd_fix branch November 18, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants