Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relval 25 step 3 ran 20% slower per event in ROOT6 that in ROOT5. Much of the problem was traced to FunctionWithDict::finalReturnType(), which constructed a TypeWithDict from the name of the function's return type every time it was called. Simply caching the return types in a concurrent_unordered_map reduced the run time of finalReturnType() by two orders of magnitude, and recovered most or all of the 20% performance deficit.
Please merge this pull request as soon as convenient.