Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cpe for 1mip #7091

Merged
merged 2 commits into from Jan 9, 2015
Merged

New cpe for 1mip #7091

merged 2 commits into from Jan 9, 2015

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Jan 8, 2015

This is an alternative option to PR #7082. This version sets the new CPE on by default, with the customization option to turn it off. Reviewers can decide which version is preferred.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

A new Pull Request was created by @wmtford for CMSSW_7_4_X.

New cpe for 1mip

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2015

@slava77
Copy link
Contributor

slava77 commented Jan 9, 2015

+1

for #7091 3cdc013

tested with higher stat tests in CMSSW_7_4_X_2015-01-07-1000 (test area sign486)

overall, results are as expected from tests done earlier by Matti for the tracking reco https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_7_4_0_pre2_v3/index.html
, and I haven't found adverse effects on higher level objects (minor changes are more or less everywhere, but don't suggest degradation in performance).

  • the effect of the PR is the largest at the strip hit level: pulls and resolutions change a lot, absolute residuals are somewhat unchanged
  • the reconstructed tracks have slightly larger chi2 with smaller peak/(reduction in population) at chi2Prob=1; otherwise track efficiency is the same and fake rates reduce a bit
  • timing is unchanged (there is some indication that it even reduces in the very high-pt jet tracking with ~20% reduction in jetCore and tobtec tracking, but stats are low and it could be a smaller single-event effect)

I post several plots below in support of comments above

3TeV dijet sample (1313.0)
wf1313_resol_v_tkwidth
wf1313_resol_v_tkwidth_lt4
wf1313_tibl1_pull
wf1313_tibl1_res

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants