Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastsim temp fix nucl interactions #7135

Merged
merged 3 commits into from Jan 13, 2015
Merged

Fastsim temp fix nucl interactions #7135

merged 3 commits into from Jan 13, 2015

Conversation

lveldere
Copy link
Contributor

Daniel Gonzalez observed a bug in nuclear interactions in tracker.
He showed that this bug has an important impact on calorimeter energies from hadrons.
He showed that when the nuclear interactions are switched off the need for the PF neutral hadron disappears.
Therefore, until nuclear interactions are fixed, we switch them off and we remove the neutral hadron fix from FastSim.

Taken actions:

  • nuclear interactions in tracker are switched off,
  • particle flow neutral hadron fix is switched off,
  • tau reconstruction configuration is now moved to a more reasonable place

@dgonzal

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_4_X.

Fastsim temp fix nucl interactions

It involves the following packages:

FastSimulation/Configuration
FastSimulation/MaterialEffects
FastSimulation/ParticleFlow

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 13, 2015
@cmsbuild cmsbuild merged commit a0e12dd into cms-sw:CMSSW_7_4_X Jan 13, 2015
@lveldere lveldere deleted the fastsim-temp-fix-nucl-interactions branch January 13, 2015 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants