Invalidate pset registration if needed #7203
Conversation
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15+MINIAODMCUP15.log you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing). |
|
Test failures are unrelated to this pull request |
cmsbuild
added
comparison-pending
core-approved
fully-signed
tests-approved
and removed
comparison-pending
core-approved
fully-signed
tests-rejected
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Invalidate pset registration if needed
Relvals involving premixed samples were failing because copies of registered parameter sets were being validated in the SecondaryEventProvider. A registered parameter set cannot be modified. So, if the validation required update access to a parameter set, the test would fail due to an assert. The fix is simply that if a copy of a registered parameter set needs modification, its registration is invalidated before update access is given to the parameter set.
Note, this request does not permit the modification of parameter sets in the parameter set registry. It only allows the modification of copies of these parameter sets.