CondTools/Ecal: drop VLA of non-POD type #7238
Conversation
This is required for Clang. This GCC and C99 extension is not allowed in
C++. Clang has only minimal support.
From Clang documentation:
The element type of a variable length array must be a POD ("plain old
data") type, which means that it cannot have any user-declared
constructors or destructors, any base classes, or any members of non-POD
type. All C types are POD types.
The patch replaces non-POD VLAs with std::vector with default-inserted
std::string instances.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_4_X. CondTools/Ecal: drop VLA of non-POD type It involves the following packages: CondTools/Ecal @ggovi, @cmsbuild, @apfeiffer1, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
CondTools/Ecal: drop VLA of non-POD type
This is required for Clang. This GCC and C99 extension is not allowed in
C++. Clang has only minimal support.
From Clang documentation:
The patch replaces non-POD VLAs with
std::vectorwith default-insertedstd::stringinstances.We also could create an array in heap. That would work also.
Please review and test the changes.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch