Fix gazillions of ICC warnings.

[ktf]

• const type qualifier on basic return type is meaningless.

[Dr15Jones]

Actually, const on some return values is useful. It keeps one from doing

foo().bar = 3;

and stops

auto & f = foo();
f.bar =3;

Which may help with the semantics of the code to avoid cases where you think you are changing the internals of foo but in reality you are not.

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Fix gazillions of ICC warnings.

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

[ktf]

I think icc complains only about basic scalar types (and my pr only fixes
those). In that case what you say does not apply (since there are no
internals) . Do you want me to amend the commit message or you still think
my pr (and icc) is wrong?
On Sat 17 Jan 2015 at 17:01 Chris Jones notifications@github.com wrote:

Actually, const on some return values is useful. It keeps one from doing

foo().bar = 3;

and stops

auto & f = foo();
f.bar =3;

Which may help with the semantics of the code to avoid cases where you
think you are changing the internals of foo but in reality you are not.

—
Reply to this email directly or view it on GitHub
#7253 (comment).

[civanch]

+1
I believe these method signatures are historical...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

[ktf]

please test

[cmsbuild]

+1
Tested at: 4702994
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7253/1985/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7253/1985/summary.html