Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoMET/METPUSubtraction: remove unused constants #7265

Merged

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Jan 19, 2015

Remove unused minPFCandToVertexAssocQuality. If you believe that this needs to stay in the code, we can add extra protection around it, otherwise lest removed it.

This is the last Clang related issue for compiling CMSSW (tested on CMSSW_7_4_DEVEL_X_2015-01-18-0200)

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_4_X.

RecoMET/METPUSubtraction: remove unused constants

It involves the following packages:

RecoMET/METPUSubtraction

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@slava77
Copy link
Contributor

slava77 commented Jan 19, 2015

@mmarionncern
Matthieu, please confirm the removal is OK

@cmsbuild
Copy link
Contributor

@mmarionncern
Copy link

Yes, it is fine, I forgot to remove it
+1

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 19, 2015

+1

for #7265 c4e1922
jenkins compiles and runs fine, no relevant diffs observed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 19, 2015
…ion-v2

RecoMET/METPUSubtraction: remove unused constants
@cmsbuild cmsbuild merged commit 5e36314 into cms-sw:CMSSW_7_4_X Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants