Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to v3 of both hf SL #7290

Merged
1 commit merged into from Jan 21, 2015
Merged

bump to v3 of both hf SL #7290

1 commit merged into from Jan 21, 2015

Conversation

davidlange6
Copy link
Contributor

there is no physics difference between v2 and v3 - just a technical performance one. This PR needs a corresponding CMSDIST change to go in first

New configuration for the shower libraries:
compressed with lzma level 4
on output, baskets are flushed every 50 events.

This unfortunately gives back the size improvement realized with v2, but does improve by a factor of 3 the speed of the v1 libraries which is of particular benefit to fastsim.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_X.

bump to v3 of both hf SL

It involves the following packages:

FastSimulation/Calorimetry
SLHCUpgradeSimulations/Configuration
SimG4Core/Application

@cmsbuild, @civanch, @nclopezo, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@lveldere
Copy link
Contributor

@davidlange6

great, thanks David

@ghost
Copy link

ghost commented Jan 21, 2015

+1
Tested together with cms-sw/cmsdist#1302, workflows 1306.0,101.0,1003.0,50101.0,9.0,25202.0 completed succesfully.
Waiting for signatures to merge both PRs.

@civanch
Copy link
Contributor

civanch commented Jan 21, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (but tests are reportedly failing).

@civanch
Copy link
Contributor

civanch commented Jan 21, 2015

Test fails because new file is not yet available to jenkins (cms-sw/cmsdist#1300 not yet in the IB)

@ghost ghost added tests-approved and removed tests-rejected labels Jan 21, 2015
ghost pushed a commit that referenced this pull request Jan 21, 2015
@ghost ghost merged commit 1bd742f into cms-sw:CMSSW_7_4_X Jan 21, 2015
@ghost ghost mentioned this pull request Jan 27, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants