New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove empty source and fix Hgg decay #7338
Conversation
A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_7_4_X. remove empty source and fix Hgg decay It involves the following packages: Configuration/Generator @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
Are the file mode changes intentional? |
No I did not issue any chmod, is this a problem? |
-1 not sure, but the executable flag might have an effect for some of the python. |
But none of these files is real python, it will not run unless interpreted by cmsDriver (at which point I believe executable mode is irrelevent) |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
remove empty source and fix Hgg decay
Thabnks a lot @covarell @bendavid for initiating this cleanup. One word of caution: both the "bot" and "IB" tests recycle existing GEN-SIM performing the matrix relval tests. It's therefore necessary to run locally an complementary tests making sure that the GEN and SIM steps are executed. Or ask @ktf / the release integration team if they can test this PR removing the "-i all" option from the runTheMatrix command. Before I noticed this PR, I had actually started it myself. For these workflows: 1340, 1348, 1349 ----- Begin Fatal Exception 25-Jan-2015 02:22:52 CET----------------------- |
This cannot be the effect of this PR, since the configuration of user_decay_file has not changed in any file. @inugent can you please have a look? |
It comes from this pull request, So I agree removing the "untracked" would be the correct fix. (Not sure exactly what the effect of the mismatched names would have been before, maybe simply that the user decay file was not loaded at all.) |
Ok, doing that |
No description provided.