Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty source and fix Hgg decay #7338

Merged
merged 2 commits into from Jan 24, 2015

Conversation

covarell
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_7_4_X.

remove empty source and fix Hgg decay

It involves the following packages:

Configuration/Generator

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@cmsbuild
Copy link
Contributor

Pull request #7338 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please check and sign again.

@covarell
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@bendavid
Copy link
Contributor

Are the file mode changes intentional?

@covarell
Copy link
Contributor Author

No I did not issue any chmod, is this a problem?

@bendavid
Copy link
Contributor

-1
(let's prevent the merging until understood)

not sure, but the executable flag might have an effect for some of the python.

@covarell
Copy link
Contributor Author

But none of these files is real python, it will not run unless interpreted by cmsDriver (at which point I believe executable mode is irrelevent)

@covarell
Copy link
Contributor Author

+1
Verified that chmod does not affect behavior of cmsDriver

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 24, 2015
remove empty source and fix Hgg decay
@cmsbuild cmsbuild merged commit 1938063 into cms-sw:CMSSW_7_4_X Jan 24, 2015
@franzoni
Copy link

Thabnks a lot @covarell @bendavid for initiating this cleanup.

One word of caution: both the "bot" and "IB" tests recycle existing GEN-SIM performing the matrix relval tests. It's therefore necessary to run locally an complementary tests making sure that the GEN and SIM steps are executed. Or ask @ktf / the release integration team if they can test this PR removing the "-i all" option from the runTheMatrix command.

Before I noticed this PR, I had actually started it myself. For these workflows: 1340, 1348, 1349

----- Begin Fatal Exception 25-Jan-2015 02:22:52 CET-----------------------
An exception of category 'Configuration' occurred while
[0] Processing run: 1 luminosityBlock: 1
[1] Calling global beginLuminosityBlock for module Pythia8GeneratorFilter/'generator'
Exception Message:
StatusMismatch: Parameter 'user_decay_file' is designated as tracked in the code,
but is designated as untracked in the configuration file.
Please remove 'untracked' from the configuration file for parameter 'user_decay_file'.
----- End Fatal Exception -------------------------------------------------

@covarell
Copy link
Contributor Author

This cannot be the effect of this PR, since the configuration of user_decay_file has not changed in any file. @inugent can you please have a look?

@bendavid
Copy link
Contributor

It comes from this pull request,
#7208

So I agree removing the "untracked" would be the correct fix. (Not sure exactly what the effect of the mismatched names would have been before, maybe simply that the user decay file was not loaded at all.)

@covarell
Copy link
Contributor Author

Ok, doing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants