Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang sa update ESD class list generation #7351

Merged
merged 5 commits into from Jan 23, 2015
Merged

Clang sa update ESD class list generation #7351

merged 5 commits into from Jan 23, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 23, 2015

This uses a python script with networkX to create a class inheritance graph. First all ESD classes are determined from by taking the type of the ESHandle template passed to dm::eventsetup::EventSetupRecord::get(). Next all classes derived from the ESD classes are added to the list. Then all member classes of these classes are added to the list. Finally all classes derived from classes on this list are added.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_4_X.

Clang sa update ESD class list generation

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

Pull request #7351 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@gartung
Copy link
Member Author

gartung commented Jan 23, 2015

Sorry. Found a typo right after submitting pull request.

@cmsbuild
Copy link
Contributor

Pull request #7351 was updated. @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Jan 23, 2015
…filter

Clang sa update ESD class list generation
@cmsbuild cmsbuild merged commit 323a7bf into cms-sw:CMSSW_7_4_X Jan 23, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants