Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pointers in static arrays const #7369

Merged
merged 1 commit into from Jan 26, 2015

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer complained that the pointers in the const arrays
were not const. Changing them to const did not change the semantics
of the algorithm.

The static analyzer complained that the pointers in the const arrays
were not const. Changing them to const did not change the semantics
of the algorithm.
@Dr15Jones
Copy link
Contributor Author

The static analyzer was complaining about the FamosProducer because of these statics.
@ktf the change is trivial so I'd vote for a signature bypass.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Make pointers in static arrays const

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

ktf added a commit that referenced this pull request Jan 26, 2015
@ktf ktf merged commit 7c6a535 into cms-sw:CMSSW_7_4_X Jan 26, 2015
@ktf
Copy link
Contributor

ktf commented Jan 26, 2015

Trivial, bypassing.

@Dr15Jones Dr15Jones deleted the makePointersInArraysConst branch March 4, 2015 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants